Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nx-plugin): add project prefix to plugin #792

Merged
merged 16 commits into from
Aug 21, 2024
Merged

feat(nx-plugin): add project prefix to plugin #792

merged 16 commits into from
Aug 21, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 14, 2024 •
edited
Loading

This PR adds the executor target as dynamic target.

  • added logic and tests
  • renamed e2e test files
  • added e2e tests

closes #619

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 961d70b with source commit 85b3cdb.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 50 🔴 43 ↓ −7.4
Code coverage 🟡 90 🟡 90 ↓ +0
Custom checks 🟡 67 🟡 67 –
Security 🟢 100 🟢 100 –
Updates 🟡 78 🟡 78 –
Accessibility 🟢 91 🟢 91 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Bug prevention 🟢 100 🟢 100 –
Code style 🟢 99 🟢 99 –
👎 2 groups regressed, 👍 2 audits improved, 👎 6 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 50 🔴 43 ↓ −7.4
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ +0

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,280 ms 🟨 Potential savings of 0 ms ↓ −100 %
Lighthouse Speed Index 🟥 5.9 s 🟥 11.0 s ↑ +88 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟨 3.8 s ↑ +22 %
Lighthouse Largest Contentful Paint 🟨 3.5 s 🟨 4.0 s ↑ +12 %
Lighthouse Time to Interactive 🟥 14.4 s 🟥 22.0 s ↑ +53 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.0 s ↓ −2 %
Code coverage Branch coverage 🟨 84.7 % 🟨 84.7 % ↓ +0 %
Code coverage Line coverage 🟩 91.9 % 🟩 91.9 % ↓ +0 %
Lighthouse Minimizes main-thread work 🟥 16.8 s 🟥 32.6 s ↑ +94 %
Lighthouse Total Blocking Time 🟥 4,900 ms 🟥 16,210 ms ↑ +230 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +53 %
Lighthouse JavaScript execution time 🟥 8.1 s 🟥 14.3 s ↑ +76 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,804 KiB 🟩 Total size was 1,809 KiB ↑ +0 %
Lighthouse Max Potential First Input Delay 🟥 2,440 ms 🟥 5,170 ms ↑ +112 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ +0 %
Lighthouse Server Backend Latencies 🟩 210 ms 🟩 330 ms ↑ +61 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 106 KiB 🟥 Potential savings of 106 KiB ↓ −22 %
Lighthouse Initial server response time was short 🟩 Root document took 360 ms 🟩 Root document took 430 ms ↑ +20 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 60 ms ↑ +127 %
Lighthouse Avoids an excessive DOM size 🟥 2,213 elements 🟥 2,209 elements ↓ +0 %

490 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review August 14, 2024 12:37
@BioPhoton BioPhoton changed the title Add project prefix to plugin feat(nx-plugin): add project prefix to plugin Aug 14, 2024
@BioPhoton BioPhoton mentioned this pull request Aug 14, 2024
Merged
@BioPhoton
Merge remote-tracking branch 'origin/main' into add-project-prefix-to…
f621d3e 
…-plugin

# Conflicts:
#	e2e/nx-plugin-e2e/tests/create-nodes-plugin.e2e.test.ts
BioPhoton and others added 2 commits August 21, 2024 02:07
@BioPhoton @matejchalk
Update constants.ts
18e16ef 
Co-authored-by: Matěj Chalk <[email protected]>
@BioPhoton @matejchalk
Update executor.target.unit.test.ts
dd3aa3f 
Co-authored-by: Matěj Chalk <[email protected]>
@BioPhoton BioPhoton enabled auto-merge (squash) August 21, 2024 00:08
@BioPhoton BioPhoton merged commit d53388d into main Aug 21, 2024
30 checks passed
@BioPhoton BioPhoton deleted the add-project-prefix-to-plugin branch August 21, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@BioPhoton BioPhoton

Labels
🧩 nx-plugin 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nx-plugin - export createNodes to have dynamic tasks
2 participants
@BioPhoton @matejchalk